Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HJ-97 - Update systems endpoint to filter vendor deleted systems #5553

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

HJ-97 - Update systems endpoint to filter vendor deleted systems #5553

wants to merge 3 commits into from

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Dec 2, 2024 •
edited
Loading

Closes #HJ-97

Description Of Changes

Update systems endpoint to filter vendor deleted systems

Code Changes

  • Updates /system list endpoint to filter out vendor deleted systems.

Steps to Confirm

For System resource:

  1. Create a system
  2. Update the vendor_deleted_at field for the newly created system to something in the past (if it is null or in the future it won't be filtered out)
  3. List /system the created system should be filtered out.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 2, 2024 8:39pm

@cypress Cypress
Copy link

cypress bot commented Dec 2, 2024 •
edited
Loading

fides    Run #11231

Run Properties:  status check passed Passed #11231  •  git commit 375ed99fe0 ℹ️: Merge 208b243cf7bccb670613258d891e8770114f75e1 into a601fbeeaece3ce7fe6c48a577ac...
Project fides
Branch Review refs/pull/5553/merge
Run status status check passed Passed #11231
Run duration 00m 49s
Commit git commit 375ed99fe0 ℹ️: Merge 208b243cf7bccb670613258d891e8770114f75e1 into a601fbeeaece3ce7fe6c48a577ac...
Committer Andres Torres
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsachs adamsachs Awaiting requested review from adamsachs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andres-torres-marroquin