Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address linting issues #5525

Merged
merged 1 commit into from
Nov 21, 2024
Merged

address linting issues #5525

merged 1 commit into from
Nov 21, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 21, 2024

Cypress tests are ignored by next lint. Here we're explicitly linting those as this will run during CI and catch issues like accidentally pushing .only tests.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 0:25am

Copy link

cypress bot commented Nov 21, 2024

fides    Run #11130

Run Properties:  status check passed Passed #11130  •  git commit a7668e74a8 ℹ️: Merge e3dfb91af08e0a4b9af0bfc501005e413998f67d into 052948dffa4892c02372fb9998c7...
Project fides
Branch Review refs/pull/5525/merge
Run status status check passed Passed #11130
Run duration 00m 36s
Commit git commit a7668e74a8 ℹ️: Merge e3dfb91af08e0a4b9af0bfc501005e413998f67d into 052948dffa4892c02372fb9998c7...
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@gilluminate gilluminate merged commit b4bbcf5 into main Nov 21, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/linting-issues branch November 21, 2024 15:51
Copy link

cypress bot commented Nov 21, 2024

fides    Run #11132

Run Properties:  status check passed Passed #11132  •  git commit b4bbcf5421: address linting issues (#5525)
Project fides
Branch Review main
Run status status check passed Passed #11132
Run duration 00m 38s
Commit git commit b4bbcf5421: address linting issues (#5525)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants