LA 88 segment md5 override #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5514/merge
|
| Run status |
|
| Run duration | 00m 41s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5514 +/- ##
==========================================
+ Coverage 78.88% 78.96% +0.07%
==========================================
Files 388 389 +1
Lines 24428 24869 +441
Branches 2669 2746 +77
==========================================
+ Hits 19270 19637 +367
- Misses 4644 4707 +63
- Partials 514 525 +11 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
galvana
reviewed
Nov 20, 2024
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ The types of changes are: | |||
| ### Added | |||
| - Added namespace support for Snowflake [#5486](https://github.com/ethyca/fides/pull/5486) | |||
| - Added support for field-level masking overrides [#5446](https://github.com/ethyca/fides/pull/5446) | |||
| - Added MD5 Hashing Request Override for segment Right to forget endpoint [#5514](https://github.com/ethyca/fides/pull/5514) | |||
There was a problem hiding this comment.
Suggested change
| - Added MD5 Hashing Request Override for segment Right to forget endpoint [#5514](https://github.com/ethyca/fides/pull/5514) | |
| - Added MD5 email hashing for Segment's Right to Forget endpoint requests [#5514](https://github.com/ethyca/fides/pull/5514) |
galvana
approved these changes
Nov 20, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 40s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA#88
Description Of Changes
Adds the Segment MD5 Hash integration Overrides, which uses a hash of the email identity instead of a dataset collection from a database.
Requires a personalized segment config to be used correctly
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated