Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add testing #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docs: add testing #303

wants to merge 2 commits into from

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented Dec 16, 2022

No description provided.

AuHau
AuHau approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but otherwise LGM.

TESTING.md
export NODE_FUNDER_PATH="<path to node-funder>"
```

Make sure you have the latest utility CLI version: `npm install --global cafe-tui`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to npm install when you use npx as it will prompt the user to install the package if it won't find it ;-)

Suggested change
Make sure you have the latest utility CLI version: `npm install --global cafe-tui`

TESTING.md

## Switching Dashboard to testnet

Grab `bee-dashboard` source and switch to branch `chore/testnet`. It contains the testnet `BZZ_TOKEN_ADDRESS` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm not sure about this approach of having a separate branch. I mean, it will soon be outdated as it won't be rebased. Having configuration options would be better...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AuHau AuHau AuHau approved these changes

@vojtechsimetka vojtechsimetka Awaiting requested review from vojtechsimetka

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cafe137 @AuHau