Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numerical Yul node id handles #15215

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Numerical Yul node id handles #15215

wants to merge 15 commits into from

Conversation

clonker
Copy link
Member

@clonker clonker commented Jun 24, 2024 •
edited
Loading

ekpyron
ekpyron reviewed Jun 25, 2024
View reviewed changes
libsolidity/ast/AST.h Outdated
yul::Block const& operations() const { return *m_operations; }
ASTPointer<std::vector<ASTPointer<ASTString>>> const& flags() const { return m_flags; }

InlineAssemblyAnnotation& annotation() const override;

private:
yul::Dialect const& m_dialect;
std::unique_ptr<yul::YulNameRepository> mutable m_yulNameRepository;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really need to be mutable? Usually that's a good indication of some design flaw :-).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, it's one place where I am not happy with the code yet :) it was already on my todo to iron out

@clonker clonker mentioned this pull request Jul 5, 2024
Open
@clonker clonker mentioned this pull request Jul 11, 2024
Merged
@clonker clonker added the has dependencies The PR depends on other PRs that must be merged first label Jul 31, 2024
@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Aug 21, 2024
@github-actions github-actions bot closed this Aug 28, 2024
@cameel cameel reopened this Aug 29, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 29, 2024
@ethereum ethereum deleted a comment from github-actions bot Aug 29, 2024
@cameel cameel removed stale The issue/PR was marked as stale because it has been open for too long. closed-due-inactivity labels Aug 29, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 13, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Sep 13, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Sep 28, 2024
@cameel cameel removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 1, 2024
@cameel cameel mentioned this pull request Oct 11, 2024
Open
4 tasks
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 15, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Oct 30, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Oct 30, 2024
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 14, 2024
@clonker clonker removed the stale The issue/PR was marked as stale because it has been open for too long. label Nov 15, 2024
@ekpyron ekpyron added the 🟡 PR review label label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekpyron ekpyron ekpyron left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
has dependencies The PR depends on other PRs that must be merged first 🟡 PR review label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clonker @ekpyron @cameel