feat: xflow integration #1597
Merged
feat: xflow integration #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/espressocash_app/pubspec.lock # packages/espressocash_app/pubspec.yaml
ookami-kb
requested changes
Nov 19, 2024
| } | ||
|
|
||
| Future<void> _selectDob() async { | ||
| final DateTime? picked = await showDatePicker( |
There was a problem hiding this comment.
IIRC, we discussed that. It shouldn't be calendar view, just an input field with proper formatting. Calendar is not convenient for selecting known date, such as date of birth.
There was a problem hiding this comment.
updated to use textfield
Comment on lines
132
to
134
| // Hardcode values for now | ||
| _country = Country.findByCode('NG'); | ||
| _idController.text = '0000000000000000004'; |
There was a problem hiding this comment.
It shouldn't be hardcoded in the app.
|
@Merculiar please resolve conflicts |
# Conflicts: # packages/espressocash_app/lib/features/activities/widgets/activity_tile.dart # packages/espressocash_app/lib/l10n/intl_en.arb # packages/espressocash_app/lib/ui/button.dart # packages/espressocash_app/lib/ui/colors.dart # packages/espressocash_app/test/golden/goldens/wallet_flow_screen.png
ookami-kb
requested changes
Nov 25, 2024
|
|
||
| if (isBrijEnabled && _brijCountries.contains(countryCode)) { | ||
| partners.add(RampPartner.brij); | ||
| } else if (_scalexCountries.contains(countryCode)) { |
There was a problem hiding this comment.
It shouldn't be else if, for the testing period, it could be both options.
| import '../../ramp/partners/kyc/widgets/launch.dart'; | ||
| import '../../ramp_partner/models/ramp_type.dart'; | ||
|
|
||
| class EcKycTile extends StatelessWidget { |
There was a problem hiding this comment.
Why Ec prefix? Why not just KycTile?
packages/espressocash_app/lib/features/kyc_sharing/screens/basic_information_screen.dart
Show resolved
Hide resolved
|
@Merculiar please resolve conflicts, and I think, we're good to go 🎉 |
# Conflicts: # packages/espressocash_app/assets/icons/star.svg # packages/espressocash_app/lib/features/profile/screens/profile_screen.dart # packages/espressocash_app/lib/l10n/intl_en.arb
|
@ookami-kb updated |
ookami-kb
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Xflow integration:
Checklist