Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update scalex withdrawals #1216

Merged
merged 26 commits into from
Jan 13, 2024
Merged

feat: update scalex withdrawals #1216

merged 26 commits into from
Jan 13, 2024

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Jan 8, 2024

Changes

  • use new scalex withdraw endpoint
  • show withdrawal fees based on partner from backend

Related issues

Fixes #1203

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (54c4666) 79.21% compared to head (4516360) 79.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1216   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files         183      183           
  Lines        4047     4047           
=======================================
  Hits         3206     3206           
  Misses        841      841           
Flag Coverage Δ
solana-beta 79.21% <ø> (?)
solana-stable 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinenerio justinenerio changed the title feat: update cashout feat: update scalex withdrawals Jan 9, 2024
@justinenerio justinenerio marked this pull request as ready for review January 9, 2024 14:40
@ookami-kb ookami-kb merged commit 1d906a7 into master Jan 13, 2024
9 checks passed
@ookami-kb ookami-kb deleted the cashout-fee-upd branch January 13, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

charge 3% fee for scalex cashout
2 participants