Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: preselect country based on locale #1204

Closed
wants to merge 5 commits into from
Closed

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Jan 3, 2024

Changes

pre select country on profile screens based on device locale

Related issues

Fixes #1200

Video

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-01-03.at.11.28.14.mp4

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio justinenerio marked this pull request as ready for review January 3, 2024 03:29
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d30f1f1) 79.21% compared to head (056d71b) 79.21%.

❗ Current head 056d71b differs from pull request most recent head 5608258. Consider uploading reports for the commit 5608258 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1204   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files         183      183           
  Lines        4047     4047           
=======================================
  Hits         3206     3206           
  Misses        841      841           
Flag Coverage Δ
solana-beta 79.21% <ø> (?)
solana-stable 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeo4934 romeo4934 closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect country and preselect the country in the setup page
2 participants