Skip to content

Commit

Permalink
Merge pull request espressif#248 from Lzw655/bugfix/lcd_breaking_chan…
Browse files Browse the repository at this point in the history
…ge_version

lcd: fix breaking change version
  • Loading branch information
espzav authored Nov 21, 2023
2 parents af5df95 + 78a3c6d commit d864d66
Show file tree
Hide file tree
Showing 11 changed files with 17 additions and 17 deletions.
3 changes: 2 additions & 1 deletion components/lcd/esp_lcd_gc9a01/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
idf_component_register(SRCS "esp_lcd_gc9a01.c"
INCLUDE_DIRS "include"
REQUIRES "driver" "esp_lcd")
REQUIRES "esp_lcd"
PRIV_REQUIRES "driver")

include(package_manager)
cu_pkg_define_version(${CMAKE_CURRENT_LIST_DIR})
4 changes: 2 additions & 2 deletions components/lcd/esp_lcd_gc9a01/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

/**
* Uncomment these lines if use custom initialization commands.
* The array should be declared as static const and positioned outside the function.
* The array should be declared as "static const" and positioned outside the function.
*/
// static const gc9a01_lcd_init_cmd_t lcd_init_cmds[] = {
// // {cmd, { data }, data_size, delay_ms}
Expand All @@ -46,7 +46,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

ESP_LOGI(TAG, "Install GC9A01 panel driver");
esp_lcd_panel_handle_t panel_handle = NULL;
// const gc9a01_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// gc9a01_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// .init_cmds = lcd_init_cmds,
// .init_cmds_size = sizeof(lcd_init_cmds) / sizeof(gc9a01_lcd_init_cmd_t),
// };
Expand Down
2 changes: 1 addition & 1 deletion components/lcd/esp_lcd_gc9a01/idf_component.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "1.2.0"
version: "2.0.0"
description: ESP LCD GC9A01
url: https://github.com/espressif/esp-bsp/tree/master/components/lcd/esp_lcd_gc9a01
dependencies:
Expand Down
1 change: 0 additions & 1 deletion components/lcd/esp_lcd_gc9a01/include/esp_lcd_gc9a01.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#pragma once

#include "hal/spi_ll.h"
#include "esp_lcd_panel_vendor.h"

#ifdef __cplusplus
Expand Down
3 changes: 2 additions & 1 deletion components/lcd/esp_lcd_ili9341/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
idf_component_register(SRCS "esp_lcd_ili9341.c"
INCLUDE_DIRS "include"
REQUIRES "driver" "esp_lcd")
REQUIRES "esp_lcd"
PRIV_REQUIRES "driver")

include(package_manager)
cu_pkg_define_version(${CMAKE_CURRENT_LIST_DIR})
4 changes: 2 additions & 2 deletions components/lcd/esp_lcd_ili9341/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

/**
* Uncomment these lines if use custom initialization commands.
* The array should be declared as static const and positioned outside the function.
* The array should be declared as "static const" and positioned outside the function.
*/
// static const ili9341_lcd_init_cmd_t lcd_init_cmds[] = {
// // {cmd, { data }, data_size, delay_ms}
Expand All @@ -46,7 +46,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

ESP_LOGI(TAG, "Install ILI9341 panel driver");
esp_lcd_panel_handle_t panel_handle = NULL;
// const ili9341_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// ili9341_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// .init_cmds = lcd_init_cmds,
// .init_cmds_size = sizeof(lcd_init_cmds) / sizeof(ili9341_lcd_init_cmd_t),
// };
Expand Down
2 changes: 1 addition & 1 deletion components/lcd/esp_lcd_ili9341/idf_component.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "1.2.0"
version: "2.0.0"
description: ESP LCD ILI9341
url: https://github.com/espressif/esp-bsp/tree/master/components/lcd/esp_lcd_ili9341
dependencies:
Expand Down
1 change: 0 additions & 1 deletion components/lcd/esp_lcd_ili9341/include/esp_lcd_ili9341.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

#pragma once

#include "hal/spi_ll.h"
#include "esp_lcd_panel_vendor.h"

#ifdef __cplusplus
Expand Down
4 changes: 2 additions & 2 deletions components/lcd/esp_lcd_st7796/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

/**
* Uncomment these lines if use custom initialization commands.
* The array should be declared as static const and positioned outside the function.
* The array should be declared as "static const" and positioned outside the function.
*/
// static const st7796_lcd_init_cmd_t lcd_init_cmds[] = {
// // {cmd, { data }, data_size, delay_ms}
Expand All @@ -54,7 +54,7 @@ Alternatively, you can create `idf_component.yml`. More is in [Espressif's docum

ESP_LOGI(TAG, "Install ST7796 panel driver");
esp_lcd_panel_handle_t panel_handle = NULL;
// const st7796_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// st7796_vendor_config_t vendor_config = { // Uncomment these lines if use custom initialization commands
// .init_cmds = lcd_init_cmds,
// .init_cmds_size = sizeof(lcd_init_cmds) / sizeof(st7796_lcd_init_cmd_t),
// };
Expand Down
2 changes: 1 addition & 1 deletion components/lcd/esp_lcd_st7796/idf_component.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
version: "1.2.0"
version: "1.2.1"
targets:
- esp32s2
- esp32s3
Expand Down
8 changes: 4 additions & 4 deletions components/lcd/esp_lcd_st7796/include/esp_lcd_st7796.h
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
#include "hal/lcd_types.h"
#include "esp_lcd_panel_vendor.h"

#ifdef __cplusplus
extern "C" {
#endif

/**
* @brief LCD panel initialization commands.
*
Expand All @@ -38,10 +42,6 @@ typedef struct {
uint16_t init_cmds_size; /*<! Number of commands in above array */
} st7796_vendor_config_t;

#ifdef __cplusplus
extern "C" {
#endif

/**
* @brief Create LCD panel for model ST7796
*
Expand Down

0 comments on commit d864d66

Please sign in to comment.