Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable Prettier #270

Merged
merged 3 commits into from
Aug 27, 2024
Merged

chore: Enable Prettier #270

merged 3 commits into from
Aug 27, 2024

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Aug 21, 2024 •
edited
Loading

This PR:

  • Install Prettier along with config
  • Enables Prettier on precommit
  • Creates a new CI task to check file format

Note: I had to disable Prettier for Markdown files because it was fixing all of the bad examples in the docs. 😄

@nzakas
Copy link
Member Author

nzakas commented Aug 27, 2024

Ping @eslint/eslint-team

mdjermanovic
mdjermanovic approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 7d918da into main Aug 27, 2024
12 checks passed
@mdjermanovic mdjermanovic deleted the prettier branch August 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzakas @mdjermanovic