-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows containers support #384
Open
joeapearson
wants to merge
9
commits into
erlang:master
Choose a base branch
from
joeapearson:windows-containers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
66b635d
Initial windows containers support
joeapearson 78da7d9
Fix from image tag
joeapearson 6d493dc
Fix from image
joeapearson 0b0d388
Add delimiters
joeapearson f6b1559
Formatting
joeapearson 147589b
Fix otp vars
joeapearson 12d448d
Set docker ctx
joeapearson 98e3a4e
Always use windows img for building
joeapearson fb0fe55
Add docs
joeapearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
# Use a separate build and distribution base image because some variants of Windows (i.e. | ||
# nanoserver) don't include the necessary dependencies to run the installer) | ||
ARG BUILD_IMAGE=mcr.microsoft.com/windows:10.0.17763.2114 | ||
ARG FROM_IMAGE=${BUILD_IMAGE} | ||
|
||
FROM $BUILD_IMAGE as build | ||
|
||
# Use powershell, fail fast on errors | ||
SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] | ||
|
||
ARG OTP_VERSION | ||
ARG OTP_HASH | ||
|
||
ADD https://github.com/erlang/otp/releases/download/OTP-${OTP_VERSION}/otp_win64_${OTP_VERSION}.exe ./otp-installer.exe | ||
|
||
# Check installer integrity | ||
RUN if ((Get-FileHash ".\otp-installer.exe" -Algorithm SHA256).Hash -ne $Env:OTP_HASH) { exit 1; } | ||
|
||
FROM $FROM_IMAGE | ||
|
||
ARG OTP_VERSION | ||
|
||
COPY --from=build ["C:/otp-installer.exe", "C:/otp-installer.exe"] | ||
|
||
# Run and cleanup the installer | ||
RUN .\otp-installer.exe /S /w /v"/qn"; \ | ||
del /f .\otp-installer.exe | ||
|
||
# This is a workaround for nanoserver where not possible to set PATH using setx or similar | ||
ENV PATH="C:\Windows\system32;C:\Windows;C:/Program Files/erl-${OTP_VERSION}/bin" | ||
|
||
# werl.exe isn't suitable here so we just use plain erl.exe; see | ||
# https://www.erlang.org/doc/man/werl.html | ||
CMD [ "erl.exe" ] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So PowerShell arbitrarily understand back- and forward-slashes? In any case, I would think it better to stick to one "style" to avoid any confusion(s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, good spot, fix coming up