silverstripe#11484, E_STRICT has been deprecated and can be removed.

erikfrerejean · Nov 29, 2024 · 4f83ea0 · 4f83ea0
1 parent 2406b75
commit 4f83ea0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/src/Core/BaseKernel.php b/src/Core/BaseKernel.php
@@ -2,6 +2,7 @@
 
 namespace SilverStripe\Core;
 
+use Exception;
 use InvalidArgumentException;
 use Monolog\Handler\StreamHandler;
 use Monolog\Logger;
@@ -21,13 +22,12 @@
 use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Core\Manifest\ModuleManifest;
 use SilverStripe\Dev\DebugView;
+use SilverStripe\Dev\Deprecation;
 use SilverStripe\Logging\ErrorHandler;
 use SilverStripe\View\PublicThemes;
 use SilverStripe\View\SSViewer;
 use SilverStripe\View\ThemeManifest;
 use SilverStripe\View\ThemeResourceLoader;
-use Exception;
-use SilverStripe\Dev\Deprecation;
 
 /**
  * Simple Kernel container
@@ -142,10 +142,10 @@ protected function bootPHP()
     {
         if ($this->getEnvironment() === BaseKernel::LIVE) {
             // limited to fatal errors and warnings in live mode
-            error_reporting(E_ALL & ~(E_DEPRECATED | E_STRICT | E_NOTICE));
+            error_reporting(E_ALL & ~(E_DEPRECATED | E_NOTICE));
         } else {
             // Report all errors in dev / test mode
-            error_reporting(E_ALL | E_STRICT);
+            error_reporting(E_ALL);
         }
 
         /**

diff --git a/src/Dev/DebugView.php b/src/Dev/DebugView.php
@@ -102,10 +102,6 @@ class DebugView
             'title' => 'User Warning',
             'class' => 'warning'
         ],
-        E_STRICT => [
-            'title' => 'Strict Notice',
-            'class' => 'notice'
-        ],
         E_RECOVERABLE_ERROR => [
             'title' => 'Recoverable Error',
             'class' => 'warning'