Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set height for .counter-visualization-container to 300px #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eradman
Copy link
Owner

@eradman eradman commented Nov 7, 2024

What type of PR is this?

  • Feature

Description

  • Set font size back to px to match most other CSS
  • Font calculation made based on counter-visualization-container, not an inner div
  • Decrease font size by 30% if optional target value is displayed
  • Scale counter fontSize using power(0.5)
  • Set embedded counter height to 100%

How is this tested?

  • Manually

- Set font size back to px to match most other CSS
- Font calculation made based on counter-visualization-container, not an inner div
- Decrease font size by 30% if optional target value is displayed
- Scale counter fontSize using power(0.5)
- Set embedded counter height to 100%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant