Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/module app/appsettings/getter #2577

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

eikeland
Copy link
Contributor

Changes:

  1. AppClient.ts

    • Added updateAppSettings method to set app settings by appKey.
    • Initialized #setSettings query in the constructor.
  2. AppModuleProvider.ts

    • Added updateAppSettings method to update app settings.
  3. App.ts

    • Added updateSettings and updateSettingsAsync methods to set app settings.
    • Added effects to monitor and dispatch events for settings updates.
  4. actions.ts

    • Added updateSettings async action for updating settings.
  5. create-reducer.ts

    • Added reducer case for updateSettings.success to update state settings.
  6. create-state.ts

    • Added handleUpdateSettings flow to handle updating settings.
  7. events.ts

    • Added new events: onAppSettingsUpdate, onAppSettingsUpdated, and onAppSettingsUpdateFailure.
  8. flows.ts

    • Added handleUpdateSettings flow to handle the set settings action.
  9. package.json

    • Added settings entry to exports and types.
  10. index.ts

    • Created new file to export useAppSettings.
  11. useAppSettings.ts

    • Created new hook for handling app settings.

Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: bd631bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@equinor/fusion-framework-module-app Minor
@equinor/fusion-framework-react-app Minor
@equinor/fusion-framework-app Patch
@equinor/fusion-framework-legacy-interopt Major
poc-portal Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 👾 React 🚀 feature New feature or request 🧬 Modules labels Nov 14, 2024
@eikeland eikeland force-pushed the feat/module-app/appsettings/getter branch from 0cfc99e to 25c7ee4 Compare November 14, 2024 14:32
@eikeland eikeland marked this pull request as ready for review November 14, 2024 14:33
@eikeland eikeland requested review from odinr and a team as code owners November 14, 2024 14:33
@eikeland eikeland self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 444695
🔵 Statements 0.39% 1746 / 444695
🔵 Functions 22.91% 203 / 886
🔵 Branches 37.02% 384 / 1037
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
cookbooks/app-react/src/App.tsx 0% 0% 0% 0% 1-30
packages/cli/src/lib/plugins/app-proxy/app-proxy-plugin.ts 0% 0% 0% 0% 1-193
packages/modules/app/src/AppClient.ts 0% 0% 0% 0% 1-244
packages/modules/app/src/AppModuleProvider.ts 0% 0% 0% 0% 1-174
packages/modules/app/src/errors.ts 0% 100% 100% 0% 3-148
packages/modules/app/src/types.ts 100% 100% 100% 100%
packages/modules/app/src/app/App.ts 0% 0% 0% 0% 1-847
packages/modules/app/src/app/actions.ts 0% 0% 0% 0% 1-80
packages/modules/app/src/app/create-reducer.ts 0% 0% 0% 0% 1-55
packages/modules/app/src/app/create-state.ts 0% 0% 0% 0% 1-41
packages/modules/app/src/app/events.ts 100% 100% 100% 100%
packages/modules/app/src/app/flows.ts 0% 0% 0% 0% 1-195
packages/modules/app/src/app/types.ts 100% 100% 100% 100%
packages/react/app/src/settings/index.ts 0% 0% 0% 0% 1
packages/react/app/src/settings/useAppSettings.ts 0% 0% 0% 0% 1-34
Generated in workflow #8091 for commit a34c705 by the Vitest Coverage Report Action

@eikeland eikeland marked this pull request as draft November 15, 2024 09:35
@github-actions github-actions bot added 💾 CLI fusion framework CLI 🚧 chore maintaines work, (update deps, workflos ...) labels Nov 15, 2024
@eikeland eikeland force-pushed the feat/module-app/appsettings/getter branch 2 times, most recently from ce2694c to 436ce93 Compare November 15, 2024 11:59
@eikeland eikeland marked this pull request as ready for review November 15, 2024 12:01
Copy link
Collaborator

@odinr odinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a quick squad code review on this feature, setting up a meeting

packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
packages/modules/app/src/app/actions.ts Show resolved Hide resolved
@eikeland eikeland force-pushed the feat/module-app/appsettings/getter branch 2 times, most recently from a34c705 to db0c0e4 Compare November 22, 2024 09:37
@eikeland eikeland force-pushed the feat/module-app/appsettings/getter branch from db0c0e4 to bd631bf Compare November 22, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🚧 chore maintaines work, (update deps, workflos ...) 💾 CLI fusion framework CLI 👨🏻‍🍳 cookbooks 🚀 feature New feature or request 🧬 Modules 👾 React
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants