Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable paths for app proxy plugin #2567

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

odinr
Copy link
Collaborator

@odinr odinr commented Nov 13, 2024

Why

Added functionality for allow providing paths for config, manifest and bundle in app-proxy-plugin. This is useful for plugins that need to load resources from a specific path.

This was required since the AppClient was changed in #2520 which broke the ability to load resources from the plugin.

Check off the following:

  • Confirm that I checked changes to branch which I am merging into.

    • I have validated included files
    • My code does not generate new linting warnings
    • My PR is not a duplicate, check existing pr`s
  • Confirm that the I have completed the self-review checklist.

  • Confirm that my changes meet our code of conduct.

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 712160c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@equinor/fusion-framework-cli Minor
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 💾 CLI fusion framework CLI 🚀 feature New feature or request labels Nov 13, 2024
@odinr odinr marked this pull request as ready for review November 13, 2024 09:58
@odinr odinr requested a review from a team as a code owner November 13, 2024 09:58
@odinr odinr requested a review from eikeland November 13, 2024 09:58
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 439767
🔵 Statements 0.39% 1746 / 439767
🔵 Functions 23.8% 219 / 920
🔵 Branches 37.34% 400 / 1071
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/bin/create-dev-serve.ts 0% 0% 0% 0% 1-166
packages/cli/src/lib/plugins/app-proxy/app-proxy-plugin.ts 0% 0% 0% 0% 1-189
Generated in workflow #8001 for commit 712160c by the Vitest Coverage Report Action

@odinr odinr merged commit 71d57c2 into main Nov 13, 2024
9 of 10 checks passed
@odinr odinr deleted the fix/cli/app-proxy-plugin/manifest-path branch November 13, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 CLI fusion framework CLI 🚀 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants