Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xmi support for mdenet education platform #1

Conversation

barnettwilliam
Copy link
Contributor

Added XMI support for the MDENet Education Platform via xmi, secondXmi, and thirdXmi field that take precedence over the Flexmi ones.

We unintentionally broke backwards compatibility by requiring an IImportManager when constructing EglTemplateSpecification objects.

We will reintroduce the old constructor to restore this compatibility (with a deprecation warning), but we might as well use the new version from now on.
@agarciadom agarciadom force-pushed the xmi-support-for-mdenet-education-platform branch from 84d5e8b to f54962a Compare February 25, 2024 17:44
@agarciadom
Copy link
Member

Thank you! I've added a test for EML merging, since that also had a check for XMI input and we weren't covering it in tests. I'll add EML support to the tool descriptor outside of this PR.

@agarciadom agarciadom merged commit 39eff63 into epsilonlabs:main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants