-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change all priors to use <dist_spec>
#871
base: main
Are you sure you want to change the base?
Conversation
otherwise they won't work on main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - this is a lot. On the face of it looks good but going to need some time to digest
This is how benchmark results would change (along with a 95% confidence interval in relative change) if deedb9e is merged into main:
|
it won't work anyway as the R code has changed too much
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 333de46 is merged into main:
|
One thing to note is that the lengthscale prior is currently not included in this, because of the extra logic in
It might be worth deciding on a single shape of the prior and then this could also be specified as a <dist_spec> (though this currently doesn't support specifying a minimum, which would either have to be dropped or functionality added).
|
Related to that merging this would enable a more comprehensive exploration of parameter choices and identifiability than what's done in #855 (not requiring editing the stan model) as we can fix parameters and/or try out different distributions with different parameters. |
I think we would need to add this as from memory it really isn't identifiable without setting some bounds |
Description
This PR closes #525 by changing all parameters to use the new interface.
In doing so and in order to keep this manageable the internals of handling parameters had to be updated a fair bit. This is now done similarly to delays in parameter arrays rather than named parameters. In principle this should make it easier to extend the model later with more parameters / probability distributions / time-varying parameters etc.
Things that could be added later fairly easy if deemed useful:
From tests it seems functionality has been preserved but it would be good for people to check if this is actually an improvement.
One thing to note is that now all parameters are initialised from (truncated) standard normal distributions so will have to monitor if this leads to any issues.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request