Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPFL News: new horizontal news template #403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

EPFL News: new horizontal news template #403

wants to merge 2 commits into from

Conversation

xentenza
Copy link
Collaborator

  • new horizontal news template
  • features a gray background option

@xentenza
EPFL News: new horizontal news template
9c4a1ab 
- new horizontal news template
- features a gray background option
@xentenza
Copy link
Collaborator Author

Pull request en mode "draft", car il manque encore quelques choses que je n'ai pas réussi:

  • dans src/epfl-news/inspector.js, il y a un nouveau terme à traduire, __('Template horizontal'. Mon PoEdit n'a pas voulu le reconnaître
  • Il y a aussi les questions de versions que j'ai peut-être faits faux;
  • Et, naturellement, un coup d'oeil et des suggestions quant au code sont les bienvenues! 😊

@xentenza
Version + langues
18c2fb9 
- versions (suite à discussion avec Luc)
- traduction anglais/français
- les traductions vers l'allemand feront l'objet d'une future PR
@xentenza xentenza marked this pull request as ready for review June 5, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdelasoie jdelasoie Awaiting requested review from jdelasoie

@lvenries lvenries Awaiting requested review from lvenries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xentenza