[김하린] 휴대폰 인증 API #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunJongHun
reviewed
Nov 26, 2023
There was a problem hiding this comment.
저는 함수를 만들어서 json 형태로 반환하는 형태를 작성했었는데, 하린님처럼 ErrorResponse Class를 만들어서 하는 방법 좋은 것 같습니다👍 저도 다음에 적용해봐야겠어요~ 덕분에 알아갑니다😄
| catch(exception: HttpException, host: ArgumentsHost) { | ||
| const ctx = host.switchToHttp(); | ||
| const response = ctx.getResponse(); | ||
| const errorResponse = new ErrorResponse(exception); |
There was a problem hiding this comment.
위에 ErrorResponse Class를 만들어 놓으니 코드가 한결 깔끔하네요!👍
|
|
||
| export class PhoneVerifyCodeRequestDto { | ||
| @IsString() | ||
| @Matches(validator.PHONE_NUMBER_REGEX) |
Comment on lines
+42
to
+49
| const phoneVerification = await this.phoneVerifyRepository | ||
| .createQueryBuilder('pv') | ||
| .where('pv.phoneNumber = :phoneNumber', { phoneNumber: dto.phoneNumber }) | ||
| .andWhere('pv.verifyCode = :verifyCode', { verifyCode: dto.verifyCode }) | ||
| .andWhere('pv.isVerified = false') | ||
| .andWhere('pv.expiredAt > NOW()') | ||
| .orderBy({ createdAt: 'DESC' }) | ||
| .getOne(); |
There was a problem hiding this comment.
저는 findOne() 함수를 통해서 가져왔는데, createQueryBuilder를 쓰면 어떤 이점이 있을까요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.