Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): no departures text visibility with many tiles #1572

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

purusott
Copy link
Collaborator

@purusott purusott commented Jul 4, 2024

Before

  • image

After

  • image

@purusott purusott requested review from oyvindgrutle, emilielr and lindtvedtsebastian and removed request for lindtvedtsebastian July 4, 2024 07:50
@emilielr
Copy link
Collaborator

emilielr commented Jul 4, 2024

Hvordan ser dette ut når det er 1 eller 2 tiles?

@purusott
Copy link
Collaborator Author

purusott commented Jul 4, 2024

Hvordan ser dette ut når det er 1 eller 2 tiles?

2 tiles:

  • image

1 tile:

image

@emilielr
Copy link
Collaborator

emilielr commented Jul 4, 2024

Bildet er veldig dratt, går det an å få til at det ikke ser slik ut? I tillegg er bildet feil. Bildet der er for lightmode, så må finne et for darkmode

@purusott purusott removed the request for review from lindtvedtsebastian July 4, 2024 11:15
@purusott
Copy link
Collaborator Author

purusott commented Jul 5, 2024

Update:

  • image
  • image
  • image

synes det er litt tricky med størrelsen på bildet og tekstens synlighet, siden det egentlig avhenger av høyden på en tile. Det justeres jo basert på antall tiles man velger å vise + skjermstørrelsen. Jeg har gjort et forsøk med responsivt bilde mtp slik det var før.

@purusott
Copy link
Collaborator Author

purusott commented Jul 8, 2024

light mode
image

@purusott purusott merged commit be2f69e into master Jul 8, 2024
3 checks passed
@purusott purusott deleted the nitpick-picture branch July 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants