-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Java to compiled language to facilitate multi-file #644
Open
JForden
wants to merge
1
commit into
engineer-man:master
Choose a base branch
from
JForden:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/bin/bash | ||
|
||
# Check if exactly one argument is provided | ||
if [ $# -eq 1 ]; then | ||
mv $1 $1.java | ||
filename=$1.java | ||
shift | ||
java $filename "$@" | ||
else | ||
# Initialize an empty array to hold the filenames | ||
declare -a javaFiles | ||
|
||
# Loop through each argument | ||
for file in "$@"; do | ||
# Check if the file already ends with .java | ||
if [[ "$file" == *.java ]]; then | ||
# If it does, add it directly to the array | ||
javaFiles+=("$file") | ||
else | ||
# If it doesn't, add .java extension then add to the array | ||
javaFiles+=("${file}.java") | ||
fi | ||
done | ||
|
||
# Compile all Java files at once | ||
javac "${javaFiles[@]}" | ||
|
||
# Run the compiled Java classes | ||
# Assuming the first argument is the main class file to run | ||
# Remove .java extension from the main class name if present | ||
mainClass="${1%.java}" | ||
# Execute the main class | ||
java "$mainClass" | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this into a
run
script -compile
should only ever compile the files.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HexF
Is there a way to conditionally trigger a run/compile depending on how many files a user submits?
This workaround is necessary for single-file submissions, as currently, for single-file submissions:
Is there a reason why we could not remove the run script and switch it to a compiled language, using the above logic scheme to maintain functionality of single file submissions?