Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 18 & Pascal 3.2.2 #493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Java 18 & Pascal 3.2.2 #493

wants to merge 2 commits into from

Conversation

My2ndAngelic
Copy link

@My2ndAngelic My2ndAngelic commented Jun 16, 2022 •
edited
Loading

Changes

  • Update repo to Java 18.0.1.1 from 15.
  • Update repo to Pascal 3.2.2 from 3.2.0
  • Did not test on my local machine but I hope it would work

@My2ndAngelic My2ndAngelic changed the title Java 18 Java 18 & Pascal 3.2.2 Jun 16, 2022
@HexF
Copy link
Collaborator

HexF commented Jun 17, 2022

did not review pr, assuming it doesn't work

(please test locally)

HexF
HexF requested changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@HexF HexF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't delete the old packages, also you will need to not edit cli/package-lock.json and package-lock.json.

Also, you claim to have updated pascal, but you have only deleted files.

packages/java/15.0.2/build.sh
Comment on lines -1 to -9
#!/usr/bin/env bash

# Put instructions to build your package in here

curl "https://download.java.net/java/GA/jdk15.0.2/0d1cfde4252546c6931946de8db48ee2/7/GPL/openjdk-15.0.2_linux-x64_bin.tar.gz" -o java.tar.gz

tar xzf java.tar.gz --strip-components=1
rm java.tar.gz

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the old version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HexF HexF HexF requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@My2ndAngelic @HexF