-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom wallpaper picker #673
base: main
Are you sure you want to change the base?
Conversation
Also I noticed today that there is a wallpaper service which isn't being used, whats up with that? |
i tried to use ags for wallpaper, but realized that causes a lot of lag and stopped using it |
ah I see. I don't have any issues when ags is running but startup takes like 15 seconds. If I can't fix that its kind of useless |
Did you ever have issues with horizontal Scrollables? If I make the images stack vertically then scrolling works as expected, if I stack them horizontally I can only scroll at the bottom of the window. (Presumably where the scroll bar is.) Scrolling with SHIFT doesn't work either. Also whenever I set Imma open an issue at ags as well ig maybe they know. |
Yes it's like what you described |
Lmao if you comment out the whole main.scss scrolling sideways works again. But if I put just a single line of CSS it's broken again. I'll mess around some more maybe I find a workaround. Also with a touchpad it works as well 🤷 |
it works now??? Both scrolling with shift and using with PopupWindow. Even when reverting to an old commit. Still same version of ags. Maybe it was an issue with gtk... |
I didn't even do a system update inbetween. No clue what i changed |
Since theme change doesn't take effect immediately for GTK apps, I'd rather not have wallpaper automatically change by default |
Okay sure that's reasonable. I'm not at home so I won't be working as much on this in the next months sadly. Also don't have a vertical monitor here, so that's gonna have to wait as well. Maybe I can use the time to read up on how gtk gallery/file apps manage thumbnails. |
You don't happen to know any way to load stuff in the background? I foud Utils.idle() but when I use that to update either the list of filenames or the array of widgets it just does it when starting up. RN whenever opening the picker first time after restarting ags it takes like 10s to load my 160 pics. Afterwards it works pretty fast. I need to find some way to work around that, e.g. like filemanagers that show a placeholder until the thumbnail loads. Tried some approaches but didn't find anything good yet. Utils.idle() works with setting the css background but that takes up way too much ram (multiple Gbs)... |
i don't |
Whats the default wallpaper folder? Set it to Also for gifs there is three options:
Probably 2) is the most reasonable option |
i say (2) with the .gif icon |
This is still WIP, I already opened the pull request to get feedback and discuss issues.
What this implements:
A window below the bar that lets you scroll through wallpapers and pick one.
Also makes some changes to the colorgen related scripts so user options
smart
andpopup
can be passed.Stuff that still needs to be done:
Gifs have no thumbnailsMake gifs distinguishableThings I couldn't get to work