Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send close frame after ASGI application returned #2332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Send close frame after ASGI application returned #2332

wants to merge 1 commit into from
+36 −23

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented May 12, 2024

No description provided.

Kludex
Kludex commented May 12, 2024
View reviewed changes
tests/protocols/test_websocket.py
@@ -581,6 +581,29 @@ async def connect(url: str):
assert exc_info.value.code == 1006


@pytest.mark.anyio
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test would hang before the changes.

@Kludex
Copy link
Member Author

Kludex commented May 14, 2024

What about the on_task_complete? Is that not being called?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kludex