Fix completions #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes completions so that they are not affected by this bug: sublimehq/sublime_text#1061 Completions triggers that contain any character not in [a-zA-Z0-9_-] cause buffers completions to block i.e. buffer completions don't work properly. Trigger descriptions use '\t' character to separate the completion from the trigger, which means they break buffer completions. There were a few other ones that had parens in the trigger too. Re: eliquious#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the completions so that they are not affected by this bug:
sublimehq/sublime_text#1061
Completions triggers that contain any character not in [a-zA-Z0-9_-]
cause buffers completions to block i.e. buffer completions don't work
properly.
Trigger descriptions use '\t' character to separate the completion from
the trigger, which means they break buffer completions.
There were a few other ones that had parens in the trigger too.
Re: #1