-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export to csv #1941
Export to csv #1941
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1941 +/- ##
============================================
- Coverage 15.99% 15.97% -0.03%
Complexity 482 482
============================================
Files 257 257
Lines 7838 7852 +14
Branches 807 808 +1
============================================
Hits 1254 1254
- Misses 6534 6548 +14
Partials 50 50 ☔ View full report in Codecov by Sentry. |
WalkthroughThe changes in the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (3)
src/main/resources/db/content_PROD/eng/images.csv
is excluded by!**/*.csv
,!**/*.csv
src/main/resources/db/content_PROD/hin/images.csv
is excluded by!**/*.csv
,!**/*.csv
src/main/resources/db/content_PROD/tgl/images.csv
is excluded by!**/*.csv
,!**/*.csv
📒 Files selected for processing (1)
src/main/java/ai/elimu/web/content/multimedia/image/ImageEditController.java
(3 hunks)
🔇 Additional comments (1)
src/main/java/ai/elimu/web/content/multimedia/image/ImageEditController.java (1)
84-84
: Addition of HttpSession
parameter is appropriate.
The inclusion of HttpSession session
in the method signature enables access to session attributes and is necessary for the new functionality.
src/main/java/ai/elimu/web/content/multimedia/image/ImageEditController.java
Show resolved
Hide resolved
src/main/java/ai/elimu/web/content/multimedia/image/ImageEditController.java
Show resolved
Hide resolved
src/main/java/ai/elimu/web/content/multimedia/image/ImageEditController.java
Show resolved
Hide resolved
To reduce memory consumption, do not call `image.getBytes()` #1933
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/main/java/ai/elimu/model/content/multimedia/Image.java
(3 hunks)src/main/java/ai/elimu/rest/v2/JpaToGsonConverter.java
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/main/java/ai/elimu/rest/v2/JpaToGsonConverter.java
🔇 Additional comments (3)
src/main/java/ai/elimu/model/content/multimedia/Image.java (3)
8-8
: LGTM: Import added for lazy loading support
The FetchType import is correctly added to support the lazy loading configuration.
Line range hint 27-31
: Consider strengthening CID field constraints post-migration
The CID field's comment indicates it's based on the file content's hash, but:
- It's not marked as @NotNull (currently commented out)
- There's no validation for CID format
- No clear indication of when it becomes mandatory
Consider adding:
- A validation annotation for CID format
- A migration timeline for making it @NotNull
- Documentation about the IPFS pinning status expectations
Let's check the current CID usage:
#!/bin/bash
# Check for CID validation or processing
rg "setCid|getCid|validateCid" --type java
# Look for IPFS/Pinata configuration
fd -e properties -e yaml -e yml | xargs rg "ipfs|pinata"
Line range hint 19-24
: Consider relaxing @NotNull constraint during migration
While deprecating and lazy-loading the bytes field aligns with the migration to IPFS, keeping it as @NotNull might cause issues during the transition period. Consider:
- Making it nullable during migration
- Adding documentation about the migration timeline
- Implementing a migration strategy for existing records
Let's verify the current usage of this field:
Issue Number
Purpose
Technical Details
Testing Instructions
Screenshots
Format Checks
Note
Files in PRs are automatically checked for format violations with
mvn spotless:check
.If this PR contains files with format violations, run
mvn spotless:apply
to fix them.