Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the method of CopulaABC #285

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add the method of CopulaABC #285

wants to merge 1 commit into from

Conversation

xuhuifan
Copy link

Summary:

Hi Henri,
Is this version works for you? I will add more test file to it soon.
Xuhui

Please make sure

  • You have updated the CHANGELOG.rst
  • You have updated the documentation (if applicable)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@vuolleko
Copy link
Member

Thanks Xuhui, looks pretty nice already! I'll have a closer look once you add some tests.

Also, the CopulaABC_Sample class is missing.

@wleoncio
Copy link
Contributor

Hi @xuhuifan, any news on the test file? The sooner we get one, the sooner we can add your contribution to the package.

Copy link
Contributor

@wleoncio wleoncio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test file and CopulaABC_Sample class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants