Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertButton: rewrite without gcr-ui #111

Merged
merged 2 commits into from
Oct 10, 2023
Merged

CertButton: rewrite without gcr-ui #111

merged 2 commits into from
Oct 10, 2023

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 10, 2023 •
edited
Loading

Required for GTK 4

Screenshot from 2023-10-10 10 37 42

  • Rewrite without using gcr-ui. This shows only what would've been shown without the expanded details. More can be added if needed, but I'm not sure it's worth doing the whole expanded cert UI like epiphany for capnet
  • Don't rebuild the entire UI when the page changes, just the parts that changed
  • Use Gtk.MenuButton
  • Code style

@danirabbit danirabbit requested a review from a team October 10, 2023 19:08
@meisenzahl
Copy link
Member

@danirabbit could you please resolve the conflict.

@danirabbit
Copy link
Member Author

@meisenzahl done!

@meisenzahl meisenzahl merged commit caa82c4 into master Oct 10, 2023
3 checks passed
@meisenzahl meisenzahl deleted the danirabbit/certbutton-nogcrui branch October 10, 2023 20:04
@danirabbit danirabbit mentioned this pull request May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisenzahl meisenzahl meisenzahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @meisenzahl