Insert jobs using the new queue #3367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
4cbd066
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7bbdbeb5.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-new-queue-insert-jo.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/new-queue/initial
branch
from
80aa6fa
to
f060abe
Compare
sandhose
force-pushed
the
quenting/new-queue/insert-jobs
branch
from
8aab159
to
28d01c0
Compare
sandhose
force-pushed
the
quenting/new-queue/initial
branch
from
f060abe
to
76afd6a
Compare
sandhose
force-pushed
the
quenting/new-queue/insert-jobs
branch
from
28d01c0
to
c3237ce
Compare
reivilibre
approved these changes
Nov 15, 2024
| fn queue_worker<'c>( | ||
| &'c mut self, | ||
| ) -> Box<dyn mas_storage::queue::QueueWorkerRepository<Error = Self::Error> + 'c> { | ||
| Box::new(PgQueueWorkerRepository::new(self.conn.as_mut())) | ||
| } | ||
|
|
||
| fn queue_job<'c>( |
There was a problem hiding this comment.
...job_queue? Minor but queue is also a verb, so this sounds like it's enqueuing a job...
There was a problem hiding this comment.
I also wasn't sure, but I try to keep the repository names close to the related table names 🤷
| .fetch_one(&pool) | ||
| .await | ||
| .expect("Deactivation job to be scheduled"); | ||
| let job: Json<serde_json::Value> = sqlx::query_scalar( |
sandhose
force-pushed
the
quenting/new-queue/initial
branch
from
76afd6a
to
2774175
Compare
sandhose
force-pushed
the
quenting/new-queue/insert-jobs
branch
from
c3237ce
to
36921bd
Compare
sandhose
force-pushed
the
quenting/new-queue/initial
branch
from
2774175
to
0495c66
Compare
sandhose
force-pushed
the
quenting/new-queue/insert-jobs
branch
from
36921bd
to
4cbd066
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3307
This removes apalis, and insert jobs in the new queue. This doesn't yet process those new jobs