Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix element call crash when resuming from notification #3926

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 22, 2024

Content

Ensure that when the call is resume when clicking on the notification, the app does not crash.

Seems that this is a regression from #3833.

Motivation and context

Fix #3905

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner November 22, 2024 10:42
@bmarty bmarty requested review from ganfra and removed request for a team November 22, 2024 10:42
// If presenter is not created at this point, it means we have no call to display, the Activity is finishing, so return early
if (!::presenter.isInitialized) {
return
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, but should prevent future crash...

Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/qjZuQR

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (5a6525a) to head (0a1c441).
Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/features/call/impl/ui/ElementCallActivity.kt 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3926      +/-   ##
===========================================
- Coverage    83.00%   82.99%   -0.01%     
===========================================
  Files         1788     1788              
  Lines        45210    45213       +3     
  Branches      5335     5337       +2     
===========================================
  Hits         37526    37526              
- Misses        5810     5813       +3     
  Partials      1874     1874              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Nov 22, 2024
@bmarty bmarty merged commit abdf6a7 into develop Nov 22, 2024
27 of 29 checks passed
@bmarty bmarty deleted the feature/bma/fixElementCallCrash branch November 22, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crash pressing the "Call in progress notification"
2 participants