Remove manual device verification which is not supported by the new cryptography stack #28588
+20
−531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/fix-usage-deprecated
branch
from
d4b922f
to
9d452d5
Compare
florianduros
force-pushed
the
florianduros/rip-out-legacy-crypto/fix-usage-deprecated
branch
from
9d452d5
to
1b35526
Compare
florianduros
changed the title
js-sdk
dbkr
reviewed
Nov 29, 2024
florianduros
changed the title
js-sdk
dbkr
approved these changes
Nov 29, 2024
|
I think this fixes #27201 ? |
richvdh
requested changes
Dec 2, 2024
| @@ -56,9 +56,6 @@ const UntrustedDeviceDialog: React.FC<IProps> = ({ device, user, onFinished }) = | |||
| <p>{askToVerifyText}</p> | |||
| </div> | |||
| <div className="mx_Dialog_buttons"> | |||
| <AccessibleButton kind="primary_outline" onClick={() => onFinished("legacy")}> | |||
There was a problem hiding this comment.
type definition for IProps above needs an update: legacy is never returned now
There was a problem hiding this comment.
(While we're at it: why not fix the type so that it something less random than "sas" | false. And document it.)
Comment on lines
+50
to
+53
| const verificationRequestPromise = matrixClient | ||
| .getCrypto() | ||
| ?.requestDeviceVerification(user.userId, device.deviceId); | ||
| setRightPanel({ member: user, verificationRequestPromise }); |
There was a problem hiding this comment.
removing the condition on action looks incorrect here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Task #26922
Closes #27201