Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element call incoming call #8941

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Element call incoming call #8941

merged 3 commits into from
Nov 12, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Nov 12, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Render incoming Element Call in the timeline as an informative tile.
Also render incoming Element Call in the notification drawer.

Motivation and context

Closes #8938

Screenshots / GIFs

ElementAndroid_IncomingElementCall.mp4

Tests

  • Run Element Android
  • In an app supporting Element Call (such as Element Web), start an Element Call
  • Observe that EA is rendering a notification and now renders the incoming call in the timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from a team and ganfra and removed request for a team November 12, 2024 14:23
@ElementBot
Copy link

ElementBot commented Nov 12, 2024

Warnings
⚠️

vector/src/main/res/layout/item_timeline_event_base_state.xml#L8 - Possible overdraw: Root element paints background ?attr/selectableItemBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)

⚠️

vector/src/main/res/layout/item_timeline_event_base_state.xml#L8 - Possible overdraw: Root element paints background ?attr/selectableItemBackground with a theme that also paints a background (inferred theme is @android:style/Theme.Holo)

Generated by 🚫 dangerJS against 12adddb

@bmarty bmarty merged commit ea170fc into develop Nov 12, 2024
15 of 17 checks passed
@bmarty bmarty deleted the feature/bma/elementCall branch November 12, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Indicate when calls are unsupported in the timeline/notifications
3 participants