Take into account well-known config to disable WorkManager network constraint #8662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate DB to 54.
…aint" is set to true in .well-known file.
No, I just tested the case by hacking the code. |
…AILED e: file:///home/runner/actions-runner/_work/element-android/element-android/matrix-sdk-android/src/test/java/org/matrix/android/sdk/internal/session/pushers/DefaultPushersServiceTest.kt:55:5 No value passed for parameter 'homeServerCapabilitiesDataSource'
… ensure that the config is retrieved. The add pusher worker can be configured before the .well-known config is retrieved.
bmarty
force-pushed
the
feature/bma/noNetworkConstraint
branch
from
8aab4a9
to
d4c6a46
Compare
giomfo
approved these changes
Oct 12, 2023
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/di/WorkManagerProvider.kt
Outdated
Show resolved
Hide resolved
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/di/WorkManagerProvider.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/org/matrix/android/sdk/internal/session/workmanager/DefaultWorkManagerConfig.kt
Show resolved
Hide resolved
…set in the .well-known file.
…m/element-android into feature/bma/noNetworkConstraint
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
"io.element.disable_network_constraint": true(@giomfo note that this is a boolean, not a String, let me know if it's OK for you)Motivation and context
Be able to run the application in air gapped mode.
Screenshots / GIFs
Tests
Tested devices
Checklist