Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow phone icon to appear for rooms with two members #8243

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ungerade
Copy link

@ungerade ungerade commented Mar 14, 2023

The call icon does not appear for rooms with exactly two members (unless the room is also "Direct"). This change should correct for this.

Type of change

  • Feature
  • [X ] Bugfix
  • Technical
  • Other :

Content

A one line change to the code. Also removed comment that
does not seem to express appropriate logic.

Motivation and context

#8244

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

The call icon does not appear for rooms with exactly two members (unless the room is also "Direct"). This change should correct for this.
@ungerade ungerade marked this pull request as ready for review March 14, 2023 09:25
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 17, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants