Fix kafka env vars #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
reviewed
Sep 19, 2024
There was a problem hiding this comment.
Thanks @andrewvc ! We have not modified this file in our fork yet, meaning that it will use the upstream configuration. Upstream file: https://github.com/open-telemetry/opentelemetry-demo/blob/main/kubernetes/opentelemetry-demo.yaml
Our recommended way of using the Otel demo is through Helm: https://github.com/elastic/opentelemetry-demo?tab=readme-ov-file#start-the-demo
We have just released the Kafka images with the inferred spans fix, it should be included in the docker compose and Helm deployments. Could you please share the reasoning behind using this raw manifest instead of Helm?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This overrides the container env vars for kafka for
OTEL_INFERRED_SPANSallowing kafka to run