Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Add securitySchemes and security in overlays #3198

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 29, 2024

Relates to elastic/docs-content#192

This PR adds overlays for the missing securityScheme and security objects.

The result is that the Elasticsearch API documents will have a page equivalent to this: https://www.elastic.co/docs/api/doc/serverless/authentication

Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌵

@lcawl lcawl merged commit 0b00127 into main Dec 2, 2024
7 checks passed
@lcawl lcawl deleted the api-authentication branch December 2, 2024 20:00
Copy link
Contributor

github-actions bot commented Dec 2, 2024

The backport to 8.16 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.16 8.16
# Navigate to the new working tree
cd .worktrees/backport-8.16
# Create a new branch
git switch --create backport-3198-to-8.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b00127e17e82f919ab246388252131269a4488c
# Push it to GitHub
git push --set-upstream origin backport-3198-to-8.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.16

Then, create a pull request where the base branch is 8.16 and the compare/head branch is backport-3198-to-8.16.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3198-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0b00127e17e82f919ab246388252131269a4488c
# Push it to GitHub
git push --set-upstream origin backport-3198-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3198-to-8.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants