Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #6160) Increase failure threshold for agent monitoring inputs from 2 to 5 #6164

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 28, 2024

What does this PR do?

Increase the default failure threshold introduced in #5999 from 2 to 5

Why is it important?

The increase of failure threshold should reduce the number of false positive DEGRADED states for elastic-agent due to transient errors.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #6160 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Nov 28, 2024
@mergify mergify bot requested a review from a team as a code owner November 28, 2024 09:40
@mergify mergify bot requested review from kaanyalti and removed request for a team November 28, 2024 09:40
@mergify mergify bot assigned pchila Nov 28, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

Copy link
Contributor Author

mergify bot commented Dec 2, 2024

This pull request has not been merged yet. Could you please review and merge it @pchila? 🙏

@pchila
Copy link
Member

pchila commented Dec 2, 2024

@Mergifyio rebase

Copy link
Contributor Author

mergify bot commented Dec 2, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]

@pchila pchila requested review from pchila and removed request for kaanyalti and andrzej-stencel December 2, 2024 07:45
@pierrehilbert pierrehilbert merged commit f19e8d2 into 8.16 Dec 2, 2024
16 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.16/pr-6160 branch December 2, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants