Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6146) [CI] Test improvement: propely collect hostnames for logging #6149

Open
wants to merge 1 commit into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 26, 2024

What does this PR do?

when GetAgentByPolicyIDAndHostnameFromList fails it prints found hostnames which are always empty.
If the agent is not found by hostname it always prints Found: [] because the hostnames are not appended to the slice. (error example)

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #6146 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner November 26, 2024 15:17
@mergify mergify bot added the backport label Nov 26, 2024
@mergify mergify bot assigned pazone Nov 26, 2024
@mergify mergify bot requested review from kaanyalti and pchila and removed request for a team November 26, 2024 15:17
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

mergify bot commented Dec 2, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

@pierrehilbert pierrehilbert requested review from pazone and removed request for kaanyalti and pchila December 2, 2024 07:49
@pierrehilbert
Copy link
Contributor

@pazone could you please follow up with this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants