Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 8.11]Elastic-agent-autodiscover to v0.6.4 #3593

Merged
merged 3 commits into from
Oct 13, 2023
Merged

[backport 8.11]Elastic-agent-autodiscover to v0.6.4 #3593

merged 3 commits into from
Oct 13, 2023

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Oct 12, 2023

  • Breaking change

What does this PR do?

WHAT: Update the Elastic-agent-autodiscover to v0.6.4. This disables by default metadata enrichment for deployment and cronjobs
WHY: The metadata enrichemnt for replicasets (which are produced from deployments) and cronjobs is proved a feature with heavy memory usage especially in big kubernetes clusters. The outcome was to enhance pods that were created from deployments and cronjobs with the relevant deployment/cronjob name. Decision

Why is it important?

We want to avoid the memory impact of keeping the feature enabled in big k8s clusters

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

@gizas gizas requested a review from a team as a code owner October 12, 2023 09:50
@gizas gizas requested review from ycombinator, pchila, ChrsMark and tommyers-elastic and removed request for a team October 12, 2023 09:50
@mergify mergify bot assigned gizas Oct 12, 2023
@gizas gizas added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Oct 12, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T06:37:59.288+0000

  • Duration: 25 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 6465
Skipped 59
Total 6524

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@gizas gizas changed the title Elastic-agent-autodiscover to v0.6.4 [backport 8.11]Elastic-agent-autodiscover to v0.6.4 Oct 12, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 12, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.78% (81/82) 👍
Files 66.667% (198/297) 👍
Classes 65.461% (362/553) 👍
Methods 52.909% (1146/2166) 👍
Lines 38.443% (13057/33965) 👎 -0.015
Conditionals 100.0% (0/0) 💚

ycombinator
ycombinator reviewed Oct 12, 2023
View reviewed changes
changelog/fragments/1697103197-updating_agentautodiscovery_811.yaml Outdated
description: Elastic-agent-autodiscover library by default comes with add_resource_metadata.deployment=false and add_resource_metadata.cronjob=false. Pods that will be created from deployments or cronjobs will not have the extra metadata field for kubernetes.deployment or kubernetes.cronjob respectively.

# Affected component; usually one of "elastic-agent", "fleet-server", "filebeat", "metricbeat", "auditbeat", "all", etc.
component:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just set this to elastic-agent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you done!

ycombinator
ycombinator reviewed Oct 12, 2023
View reviewed changes
changelog/fragments/1697103197-updating_agentautodiscovery_811.yaml Outdated
# If not present is automatically filled by the tooling finding the PR where this changelog fragment has been added.
# NOTE: the tooling supports backports, so it's able to fill the original PR number instead of the backport PR number.
# Please provide it if you are adding a fragment for a different PR.
#pr: https://github.com/owner/repo/1234
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set this field to the PR's URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@gizas
Copy link
Contributor Author

gizas commented Oct 13, 2023

/test

@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gizas
Copy link
Contributor Author

gizas commented Oct 13, 2023

@pierrehilbert shall I merge as well? Only vulncheck is failing

@pierrehilbert pierrehilbert merged commit 7820aea into 8.11 Oct 13, 2023
8 of 11 checks passed
@pierrehilbert pierrehilbert deleted the updating_agentautodiscovery_811 branch October 13, 2023 11:29
@gizas gizas mentioned this pull request Sep 13, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator left review comments

@ChrsMark ChrsMark ChrsMark approved these changes

@cmacknz cmacknz cmacknz approved these changes

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@tommyers-elastic tommyers-elastic Awaiting requested review from tommyers-elastic

Assignees

@gizas gizas

Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gizas @elasticmachine @ycombinator @cmacknz @ChrsMark @pierrehilbert