-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Agent incapable of running on Azure Container Instances #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 1bf9027.
michalpristas
added
bug
Something isn't working
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Team:Elastic-Agent
Label for the Agent team
labels
Oct 10, 2023
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
NOTE: |
michalpristas
added
backport-v8.11.0
Automated backport with mergify
and removed
backport-skip
labels
Oct 10, 2023
🌐 Coverage report
|
pchila
reviewed
Oct 10, 2023
dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
Outdated
Show resolved
Hide resolved
…tmpl Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
cmacknz
reviewed
Oct 11, 2023
SonarQube Quality Gate |
cmacknz
approved these changes
Oct 16, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
What this change is introducing on top of bringing back work introduced in #3084 is change of ordrer for some operations. Changing owner of a file, discards capabilities set. This becomes a problem with heartbeat as it needs setuid and netraw capabilities to perform properly. So setting capabilities was moved after chown. (cherry picked from commit fa357a8)
michalpristas
added a commit
that referenced
this pull request
Oct 18, 2023
…#3614) What this change is introducing on top of bringing back work introduced in #3084 is change of ordrer for some operations. Changing owner of a file, discards capabilities set. This becomes a problem with heartbeat as it needs setuid and netraw capabilities to perform properly. So setting capabilities was moved after chown. (cherry picked from commit fa357a8) Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
cmacknz
added a commit
to cmacknz/elastic-agent
that referenced
this pull request
Nov 6, 2023
…elastic#3576) (elastic#3614)" This reverts commit 7eb6e4a.
cmacknz
added a commit
that referenced
this pull request
Nov 7, 2023
cmacknz
added a commit
to cmacknz/elastic-agent
that referenced
this pull request
Nov 7, 2023
…elastic#3576)" This reverts commit fa357a8.
cmacknz
added a commit
that referenced
this pull request
Nov 7, 2023
michalpristas
added a commit
to michalpristas/elastic-agent
that referenced
this pull request
Nov 16, 2023
…nstances (elastic#3576)" (elastic#3723)" This reverts commit 29386eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.11.0
Automated backport with mergify
bug
Something isn't working
Team:Elastic-Agent
Label for the Agent team
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing back #3139
What this change is introducing on top of bringing back work introduced in #3084 is change of ordrer for some operations.
Changing owner of a file, discards capabilities set. This becomes a problem with heartbeat as it needs
setuid
andnetraw
capabilities to perform properly.So setting capabilities was moved after chown.
How to test
docker run --rm -it --entrypoint /bin/bash {image_id} -c "getcap data/elastic-agent-*/components/heartbeat"
-> this needs to have output (capabilities mentioned earlier)I also checked with @justinkambic to see if we can test this with their failing E2E but it seems we need to merge it to see it fail. But it won't fail. OK?
Fixes: #82