Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 4.x from main for v4.5.1 docs build #3967

Merged
merged 44 commits into from
Apr 11, 2024
Merged

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 11, 2024

No description provided.

dependabot bot and others added 30 commits March 17, 2024 22:19
- use more reliable 'elastic' org membership test for triage, etc. labels
- bypass 'action-add-labels' action to avoid another dep
- drop agent-nodejs label that we no longer require for use in GH projects

Fixes: #3884
This adds the require zookeeper volume refs.

Closes: #3922
…14 (#3927)

This was necessitated by a transitive dep of tedious (`@azure/core-rest-pipeline`)
breaking support for Node.js versions earlier than 16.

Closes: #3926
…outside of CI (#3928)

Running 'npm test' outside of CI will start all test services in docker
*then wait for them to all be healthy*. Without a healthcheck for zk
the 'wait_for_healthy' in test/script/run_tests.sh would never pass.
Specifying the mssql image platform is necessary on *arm* Macs
because the mssql Docker image only provides binaries for the
amd64 architecture. My understanding is that Rosetta emulation
on recent macOS supports running the amd binary just fine.
Updates `eslint-plugin-license-header` from 0.6.0 to 0.6.1
dependabot bot and others added 14 commits April 1, 2024 10:36
…v-dep, transitive from @elastic/transport (#3949)

The elasticsearch-canary version was very old. In practice we weren't updated it,
hence there was no value in testing these.

Refs: #3948
…nt flat file config (#3954)

In eslint@9 there is a new suggested config file format ("flat")
https://github.com/eslint/rfcs/tree/main/designs/2019-config-simplification
https://eslint.org/docs/latest/use/configure/configuration-files

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: David Luna <luna.bistuer@gmail.com>
Co-authored-by: Trent Mick <trent.mick@elastic.co>
…ented HTTP requests (#3965)

... because Elasticsearch borks on these requests. This case should only be
possible in a weird case like having two APM agents active.

Fixes: #3964
@trentm trentm requested a review from david-luna April 11, 2024 18:07
@trentm trentm self-assigned this Apr 11, 2024
@trentm
Copy link
Member Author

trentm commented Apr 11, 2024

This is a first attempt at this, rather than the force-push update we used to use.

Commands used to create this:

git checkout 4.x
git checkout -b trentm/docs-4x-update-from-main
git rebase main
gh pr create --fill -w -B 4.x

@trentm
Copy link
Member Author

trentm commented Apr 11, 2024

Sanity test that this branch is the same state as "main":

mkdir /tmp/check-it
cd /tmp/check-it
git clone git@github.com:elastic/apm-agent-nodejs.git
git clone git@github.com:elastic/apm-agent-nodejs.git apm-agent-nodejs-4x
cd apm-agent-nodejs-4x
git checkout trentm/docs-4x-update-from-main
cd ..
diff -ur -x .git apm-agent-nodejs apm-agent-nodejs-4.x

That diff should have no output.

% diff -ur -x .git apm-agent-nodejs apm-agent-nodejs-4.x
%

@trentm
Copy link
Member Author

trentm commented Apr 11, 2024

Failing workflows:

  • issue labeler
  • release

Unfortunate added workflow runs to the release process:

  • A re-run of a TAV workflows

@trentm trentm merged commit bdc1f50 into 4.x Apr 11, 2024
204 of 208 checks passed
@trentm trentm deleted the trentm/docs-4x-update-from-main branch April 11, 2024 18:19
@trentm
Copy link
Member Author

trentm commented Apr 11, 2024

The process here should be that I wait for the "buildkite/docs-build-pr" check to pass before merging.

However, I thought that would have been a "required check" to be allowed to merge. hrm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants