fix(next, redis, mongodb): ensure module sub-path RITM hooks are applied on Windows #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ied on Windows For some instrumentations we path module sub-paths (e.g. mongodb/lib/foo.js). On Windows RITM returns modPath=mongodb\lib\foo.js. This change adds path separator normalization so those values equate. Before this the module patcher for that subpath was not applied.
david-luna
approved these changes
Mar 9, 2024
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…ied on Windows (elastic#3905) For some instrumentations we path module sub-paths (e.g. mongodb/lib/foo.js). On Windows RITM returns modPath=mongodb\lib\foo.js. This change adds path separator normalization so those values equate. Before this the module patcher for that subpath was not applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some instrumentations we path module sub-paths (e.g. mongodb/lib/foo.js).
On Windows RITM returns modPath=mongodb\lib\foo.js. This change adds path
separator normalization so those values equate. Before this the module
patcher for that subpath was not applied.
This impacts instrumentation for Next.js, redis v4+, and part of the instrumentation for mongodb.
The reason this wasn't caught in testing is because: