Skip to content

Commit

Permalink
chore: bump min Node.js to v14.17; update deps (#3611)
Browse files Browse the repository at this point in the history
This bumps the mininum supported Node.js from v14.5 to v14.17;
and bumps a number of dependencies.

- v14.5 was for AsyncLocalStorage
- v14.6 brings a V8 with spport for private methods syntax, FinalizationRegistry (used by pino@8)
- v14.8 brings AsyncResource.bind
- v14.17 brings AbortController, AbortSignal.reason (used by readable-stream@4, glob@10, etc.)

Closes: #2760
  • Loading branch information
trentm authored Sep 6, 2023
1 parent 51f6e5f commit b8df297
Show file tree
Hide file tree
Showing 13 changed files with 1,407 additions and 791 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ jobs:
- '16'
- '16.0'
- '14'
- '14.0'
- '14.17'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ See the <<upgrade-to-v4>> guide.
[float]
===== Breaking changes
* Set the new minimum supported Node.js to version 14.5.0.
* Set the new minimum supported Node.js to version 14.17.0.
Users of earlier Node.js versions can use elastic-apm-node v3.x, which
supports back to Node.js v8.6.
Expand Down
2 changes: 1 addition & 1 deletion docs/supported-technologies.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ Versions of Node.js past their end-of-life date are not supported.

image::./images/node_release_schedule.svg[Node.js release schedule]

APM agent 4.x releases work with Node.js versions 14.5.0 and later.
APM agent 4.x releases work with Node.js versions 14.17.0 and later.
APM agent 3.x maintenance releases work with Node.js versions 8.6 and later.
We will only break support for older Node.js versions with a major version release of the APM agent.

Expand Down
2 changes: 1 addition & 1 deletion docs/upgrade-to-v4.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ The following is a guide on upgrading your usage of the Elastic APM Node.js agen
[[v4-nodejs]]
==== Node.js versions

Version 4.x of `elastic-apm-node` supports Node.js v14.5.0 and later.
Version 4.x of `elastic-apm-node` supports Node.js v14.17.0 and later.
(The previous 3.x major supported back to Node.js v8.6.0.)


Expand Down
4 changes: 2 additions & 2 deletions lib/apm-client/http-apm-client/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function Client(opts) {
// - `null`: the APM server version is unknown, could not be determined
// - a semver.SemVer instance
this._apmServerVersion = this._conf.apmServerVersion
? semver.SemVer(this._conf.apmServerVersion)
? new semver.SemVer(this._conf.apmServerVersion)
: undefined;
if (!this._apmServerVersion) {
this._fetchApmServerVersion();
Expand Down Expand Up @@ -1491,7 +1491,7 @@ Client.prototype._fetchApmServerVersion = function () {
? serverInfo.ok.version
: serverInfo.version;
try {
this._apmServerVersion = semver.SemVer(verStr);
this._apmServerVersion = new semver.SemVer(verStr);
} catch (verErr) {
setVerUnknownAndNotify(
`could not parse APM Server version "${verStr}": ${verErr.message}`,
Expand Down
Loading

0 comments on commit b8df297

Please sign in to comment.