Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility option #29

Closed
wants to merge 2 commits into from
Closed

Add visibility option #29

wants to merge 2 commits into from

Conversation

saleyn
Copy link

@saleyn saleyn commented Sep 1, 2022

Implement the visibility option discussed in #27

@ejpcmac
Copy link
Owner

ejpcmac commented Sep 2, 2022

Hello @saleyn, thank you for your PR! I will review it in the days to come.

@ejpcmac
Copy link
Owner

ejpcmac commented Sep 18, 2022

Hello, I didn’t have the time to review your PRs yet due to a quick increase in my workload on many professional / personal subjects at the same time, which should still be quite high for the coming week and should be decreasing the week after.

I just see that you are targeting the main branch. As stated in the CONTRIBUTING.md, could you please rebase your changes on top of develop and re-target your PRs to develop as well? The CI does not run on main due to this. Also, commits should be named according to Conventional Commits and use the types defined in the configuration. You can take your inspiration from existing commits in the repo.

After that I’ll review and merge this PR first, then your other PR later.

@saleyn
Copy link
Author

saleyn commented Sep 19, 2022

Ok. I think I'll just do that with the 2nd PR, because it's inclusive of the 1st one.

@saleyn saleyn closed this Sep 19, 2022
@saleyn
Copy link
Author

saleyn commented Sep 19, 2022

Closing this PR because it's included in the PR #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants