feat: add routes for /img/ with configurable upload limit #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
wkillerud,
leftieFriele,
trygve-lie,
tor0405 and
flatoy
and removed request for
wkillerud
wkillerud
approved these changes
Aug 14, 2024
lib/main.js
Outdated
| @@ -20,6 +20,7 @@ import * as utils from './utils.js'; | |||
| * @property {string} [notFoundCacheControl="public, max-age=5"] | |||
| * @property {number} [pkgMaxFileSize=10000000] The limit in bytes before PUT /pkg/ starts returning 413 Content Too Large | |||
| * @property {number} [mapMaxFileSize=1000000] The limit in bytes before PUT /map/ starts returning 413 Content Too Large | |||
| * @property {number} [imgMaxFileSize=10000000] The limit in bytes before PUT /img/ starts returning 413 Content Too Large | |||
There was a problem hiding this comment.
Do we maybe want to set the default here higher, like 20_000_000?
There was a problem hiding this comment.
err, I just realised, we don't actually set default values, we just say we do in the types...
|
🎉 This issue has been resolved in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 3 of adding support for an /img namespace to Eik servers
Needs: eik-lib/common#326 and eik-lib/core#440
This PR completes the work needed on the server side. Subsequent work may need to be done in the CLI to add support for uploading to /img. (Or not, it might just work since it's just an additional option for the type field.