Skip to content

Commit

Permalink
chore: exclude node 18 on windows on ci
Browse files Browse the repository at this point in the history
For an unknown reason the upload tests fail on Node 18 on Windows
with an ECONNRESET from node-fetch. Debugging hasn't revealed any
probable cause.

- The fixture readable stream works as expected on Node 18 on Windows
- Other requests to the server work as expected

Refactoring to use native fetch means we lose the option to override
the origin hostname, which we use to test server validation.
  • Loading branch information
wkillerud committed Aug 19, 2024
1 parent c01dfcf commit 706541b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
node-version: [18, 20]
exclude:
- os: windows-latest
node-version: 18 # upload tests fail with ECONNRESET for unknown reasons on Node 18 on Windows
runs-on: ${{ matrix.os }}

steps:
Expand Down

0 comments on commit 706541b

Please sign in to comment.