Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: static_cast<float>(sqrt(...)) to avoid c++-narrowing warning/error (again) #1682

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: static_cast<float>(sqrt(...)) to avoid c++-narrowing warning/error (again) #1682

merged 1 commit into from
Dec 1, 2024

Conversation

wdconinc
Copy link
Contributor

Briefly, what does this PR introduce?

#1675 again see there.

@github-actions github-actions bot added the topic: tracking Relates to tracking reconstruction label Nov 29, 2024
@wdconinc wdconinc requested a review from veprbl November 29, 2024 23:59
veprbl
veprbl approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, there is a bit of code duplication. We need to change both instances.

@wdconinc wdconinc added this pull request to the merge queue Dec 1, 2024
Merged via the queue into main with commit 3a507b8 Dec 1, 2024
85 of 87 checks passed
@wdconinc wdconinc deleted the wdconinc-patch-3 branch December 1, 2024 16:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

Capybara summary for PR 1682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
topic: tracking Relates to tracking reconstruction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wdconinc @veprbl