Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realistic BTOF digitization #1635

Open
wants to merge 86 commits into
base: main
Choose a base branch
from
Open

Realistic BTOF digitization #1635

wants to merge 86 commits into from

Commits on Jul 18, 2024

  1. First commit of BTOF digitization code!

    @ssedd1123
    ssedd1123 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8123783 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Update BTOFHitDigi.cc

    @eicsouvik
    eicsouvik authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    2332d18 View commit details
    Browse the repository at this point in the history

  2. Update BTOFHitDigi.h

    @eicsouvik
    eicsouvik authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    4b907cb View commit details
    Browse the repository at this point in the history

  3. Update BTOFHitDigi.cc

    @eicsouvik
    eicsouvik authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    204d472 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #3 from eicsouvik/patch-1 

    Update BTOFHitDigi.cc
    @ssedd1123
    ssedd1123 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1b08022 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2 from eicsouvik/patch-2 

    Update BTOFHitDigi.h
    @ssedd1123
    ssedd1123 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5e011e1 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #1 from eicsouvik/patch-3 

    Update BTOFHitDigi.cc
    @ssedd1123
    ssedd1123 authored Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5e17954 View commit details
    Browse the repository at this point in the history

  7. Changed the algorithm of BarrelTOFNeighborFinder so it's more intuita… 

    …tive.
    Desktop ssedd1123 authored and Desktop ssedd1123 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    9fbe640 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of https://github.com/ssedd1123/EICrecon

    Desktop ssedd1123 authored and Desktop ssedd1123 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    171ffd4 View commit details
    Browse the repository at this point in the history

  9. Changed spread calculation. Originally the spread were estimated with… 

    … distance relative to the center of the center cell. Now it's changed so spread is calculated relative to the true hit location.
    Desktop ssedd1123 authored and Desktop ssedd1123 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    52a9b33 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Fixed bugs when sensor ID from barrelTOFNeighborFinder gives wrong ne… 

    …ighbors when cell ID from BitFieldDecoder for cellID is negative.
    @ssedd1123
    ssedd1123 committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    54024b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Merge branch 'eic:main' into main

    @ssedd1123
    ssedd1123 authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    5e1cec4 View commit details
    Browse the repository at this point in the history

  2. Updated BTOF neighbor finder. To be used with updated epic geometry w… 

    …ith dead spaces implemented.
    @ssedd1123
    ssedd1123 committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    40abca0 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'eic:main' into main

    @ssedd1123
    ssedd1123 authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    72edf8b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'eic:main' into main

    @ssedd1123
    ssedd1123 authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    df48d16 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'eic:main' into main

    @ssedd1123
    ssedd1123 authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1d3c040 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Sync fork.

    @ssedd1123
    ssedd1123 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    1adfd02 View commit details
    Browse the repository at this point in the history

  2. Added missing closing parenthesis.

    @ssedd1123
    ssedd1123 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    f373972 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Use more realistic charge sharing parameters and bug fix on ADC heights.

    @ssedd1123
    ssedd1123 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0725492 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of https://github.com/ssedd1123/EICrecon

    @ssedd1123
    ssedd1123 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a451aed View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Fixed incorrect threshold for ADC TDC.

    @ssedd1123
    ssedd1123 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ce9122d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'eic:main' into main

    @ssedd1123
    ssedd1123 authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    08c83e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Move digitization code to the main branch.

    @ssedd1123
    ssedd1123 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    350ca3b View commit details
    Browse the repository at this point in the history

  2. Formated files.

    @ssedd1123
    ssedd1123 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4f892ee View commit details
    Browse the repository at this point in the history

  3. Included config content in parameter ref.

    @ssedd1123
    ssedd1123 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    8d8a12a View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'new-origin/main' into pr/BTOF-digitizat… 

    …ion-clusterization
    @ssedd1123
    ssedd1123 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d260635 View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    875f0f4 View commit details
    Browse the repository at this point in the history

  6. Fixed BTOF reco uncertainty estimation bug.

    @ssedd1123
    ssedd1123 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b12ee38 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0d91db5 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Removed reconstruction for later pull request. Breaks TOF digi into t… 

    …hree parts: 1. Charge sharing, 2. Pulse generation, 3. Pulse digitization.
    @ssedd1123
    ssedd1123 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    34f4daa View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    9ab01c9 View commit details
    Browse the repository at this point in the history

  3. Removed legacy modification to JEventProcessorPODIO.cc

    @ssedd1123
    ssedd1123 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    4cf1216 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'pr/BTOF-digitization-clusterization' of https://github.… 

    …com/eic/EICrecon into pr/BTOF-digitization-clusterization
    @ssedd1123
    ssedd1123 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    83c9b88 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    deaf63c View commit details
    Browse the repository at this point in the history

  6. Fixed bugs on charge sharing calculation. It was assumed that all gea… 

    …nt hits on BTOF occurs at the center of a BTOF cell. That may not be true. It has been fixed.
    @ssedd1123
    ssedd1123 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    14889de View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    7474a52 View commit details
    Browse the repository at this point in the history

  8. Moved algorithms away from src/detectors.

    @ssedd1123
    ssedd1123 committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    569090d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Fix spelling mistakes to make codespell happy.

    @ssedd1123
    ssedd1123 committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    33c6587 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Removed unnecessary header files.

    @ssedd1123
    ssedd1123 committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b28d49f View commit details
    Browse the repository at this point in the history

  2. Trigger Build

    @ssedd1123
    ssedd1123 committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    8f01587 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    595952d View commit details
    Browse the repository at this point in the history

  2. Update src/algorithms/digi/BTOFChargeSharing.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    a4b5211 View commit details
    Browse the repository at this point in the history

  3. Update src/algorithms/digi/TOFPulseDigitization.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f4f3204 View commit details
    Browse the repository at this point in the history

  4. Update src/algorithms/digi/TOFPulseDigitization.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    76fccd8 View commit details
    Browse the repository at this point in the history

  5. Update src/algorithms/digi/BTOFChargeSharing.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    310c510 View commit details
    Browse the repository at this point in the history

  6. Update src/algorithms/digi/TOFPulseDigitization.h 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    6e44318 View commit details
    Browse the repository at this point in the history

  7. Update src/algorithms/digi/TOFPulseGeneration.h 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7ecc458 View commit details
    Browse the repository at this point in the history

  8. Update src/algorithms/digi/BTOFChargeSharing.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    41614b8 View commit details
    Browse the repository at this point in the history

  9. Update src/algorithms/digi/BTOFChargeSharing.h 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7ca28d3 View commit details
    Browse the repository at this point in the history

  10. Update src/algorithms/digi/BTOFChargeSharing.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    576055c View commit details
    Browse the repository at this point in the history

  11. Replaced magic number in BTOFChargeSharing with the correct unit.

    @ssedd1123
    ssedd1123 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    232a3ef View commit details
    Browse the repository at this point in the history

  12. Make clang-tidy-iwyu happy.

    @ssedd1123
    ssedd1123 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    8043bff View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Trigger Build

    @ssedd1123
    ssedd1123 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    837900a View commit details
    Browse the repository at this point in the history

  2. Update src/algorithms/digi/TOFPulseGeneration.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    e51c007 View commit details
    Browse the repository at this point in the history

  3. Update src/algorithms/digi/TOFPulseGeneration.cc 

    Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
    @ssedd1123 @veprbl
    ssedd1123 and veprbl authored Nov 2, 2024
    Configuration menu
    Copy the full SHA
    1d3f592 View commit details
    Browse the repository at this point in the history

  4. Make clang-tidy-iwyu happy.

    @ssedd1123
    ssedd1123 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    3e0afdc View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. TOFPulseGeneration_factory.h: mixedCase for parameter names

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    89452f4 View commit details
    Browse the repository at this point in the history

  2. TOFPulseDigitization_factory.h: ditto

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d0040c6 View commit details
    Browse the repository at this point in the history

  3. TOFPulseDigitization_factory.h: missed

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    bbc6ab0 View commit details
    Browse the repository at this point in the history

  4. BTOFChargeSharing_factory.h: ditto

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    5664496 View commit details
    Browse the repository at this point in the history

  5. TOFHitDigiConfig.h: rm unused suff

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    00d1890 View commit details
    Browse the repository at this point in the history

  6. BTOFChargeSharing_factory.h: need algorithmsInit

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    3af27a9 View commit details
    Browse the repository at this point in the history

  7. TOFPulseDigitization_factory.h: ditto

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    cb3209d View commit details
    Browse the repository at this point in the history

  8. TOFPulseGeneration_factory.h: ditto

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6ba7bab View commit details
    Browse the repository at this point in the history

  9. BTOFChargeSharing.h: remove cache stuff for now

    @veprbl
    veprbl authored Nov 4, 2024
    Configuration menu
    Copy the full SHA
    fa7ad55 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @veprbl
    veprbl authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5f092d4 View commit details
    Browse the repository at this point in the history

  2. JEventProcessorPODIO.cc: add TOFBarrelADCTDC

    @veprbl
    veprbl authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ef00944 View commit details
    Browse the repository at this point in the history

  3. Update src/services/io/podio/JEventProcessorPODIO.cc

    @veprbl
    veprbl authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a745e2b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Added tests for TOFPulseDigitization and TOFPulseGeneration.

    @ssedd1123
    ssedd1123 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dd95d6b View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary credits.

    @ssedd1123
    ssedd1123 committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    d073d6b View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    6e34d8a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    22c9fe4 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 18, 2024
    Configuration menu
    Copy the full SHA
    ce7b6a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Update src/algorithms/digi/TOFHitDigiConfig.h 

    Co-authored-by: Derek M Anderson <derek.murphy.anderson@protonmail.com>
    @ssedd1123 @ruse-traveler
    ssedd1123 and ruse-traveler authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d732550 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    aef5225 View commit details
    Browse the repository at this point in the history

  3. Amplitude of Landau pulse is now a configurable parameter.

    @ssedd1123
    ssedd1123 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    40cf825 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    fbde72c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. Beginning time of TOFPulse is now aligned to the beginning of clock c… 

    …ycle. Units are also added to TOFHitDigiConfig.
    @ssedd1123
    ssedd1123 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    da1321b View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    515eba4 View commit details
    Browse the repository at this point in the history

  3. Make clang-tidy-iwyu happy.

    @ssedd1123
    ssedd1123 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    fcb0e07 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 22, 2024
    Configuration menu
    Copy the full SHA
    5f3d182 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @ssedd1123
    ssedd1123 authored Nov 25, 2024
    Configuration menu
    Copy the full SHA
    a1455a8 View commit details
    Browse the repository at this point in the history

  2. Fix typo in code.

    @ssedd1123
    ssedd1123 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    9551964 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Trigger Build

    @ssedd1123
    ssedd1123 committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3d4638c View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. Merge branch 'main' into pr/BTOF-digitization-clusterization

    @veprbl
    veprbl authored Dec 1, 2024
    Configuration menu
    Copy the full SHA
    99d7bd8 View commit details
    Browse the repository at this point in the history

  2. apply clang-format

    @veprbl
    veprbl committed Dec 1, 2024
    Configuration menu
    Copy the full SHA
    29239b7 View commit details
    Browse the repository at this point in the history