Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new pdf.js build #2675

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

new pdf.js build #2675

wants to merge 5 commits into from

Conversation

panaC
Copy link
Member

@panaC panaC commented Nov 22, 2024 •
edited
Loading

src/typings and resources/lib/pdf.js removed

Fixes #2669
Fixes #2667

@panaC
new pdf.js build from npm https://github.com/edrlab/pdf.js
f9636d1 
need to remove the src/resources/lib/pdfjs
@panaC panaC self-assigned this Nov 22, 2024
@panaC
Copy link
Member Author

panaC commented Nov 26, 2024

@danielweck In this PR you will find :

  • src/typings and src/resources/lib/pdfjs folder are removed and replace by pdf.js node_modules from github fork.
  • target new edrlab/pdf.js branch : master2 to node_modules/pdf.js
  • master2 is a branch from the last mozilla commit : mozilla/pdf.js@079eb24 and patched with this commit edrlab/pdf.js@4ed465d
  • I replace pdfjs:// fileProtocol to thoriumhttps:// StreamProtocol to handle the worker script module and bypass cors security

@panaC panaC marked this pull request as ready for review November 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck Awaiting requested review from danielweck

Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PDF] pages are no longer centered but shifted to the right update PDF.JS engine
1 participant
@panaC