Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): Update singer-sdk requirement from ~=0.38.0 to ~=0.39.0 #50

Merged
merged 2 commits into from
Aug 5, 2024
Merged

feat(deps): Update singer-sdk requirement from ~=0.38.0 to ~=0.39.0 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65385db
feat(deps): Update singer-sdk requirement from ~=0.38.0 to ~=0.39.0
dependabot[bot] Aug 5, 2024
a0bfddc
Fix types
edgarrmondragon Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ dynamic = [
dependencies = [
"requests<3,>=2",
"requests-cache<2,>=1",
"singer-sdk~=0.38.0",
"singer-sdk~=0.39.0",
]
optional-dependencies.dev = [
"tap-clinicaltrials[testing,typing]",
Expand Down
5 changes: 3 additions & 2 deletions tap_clinicaltrials/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

if t.TYPE_CHECKING:
import requests
from singer_sdk.helpers.types import Context


class Studies(RESTStream[str]):
Expand Down Expand Up @@ -40,7 +41,7 @@ def requests_session(self) -> requests.Session:

def get_url_params(
self,
context: dict[str, t.Any] | None,
context: Context | None,
next_page_token: str | None,
) -> dict[str, t.Any] | str:
"""Return a dictionary of parameters to use in the request URL.
Expand Down Expand Up @@ -83,7 +84,7 @@ def get_url_params(
def post_process(
self,
row: dict[str, t.Any],
context: dict[str, t.Any] | None = None, # noqa: ARG002
context: Context | None = None, # noqa: ARG002
) -> dict[str, t.Any] | None:
"""Return a modified data row."""
row["nctId"] = row["protocolSection"]["identificationModule"]["nctId"]
Expand Down